Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] update reva to e2232b5a63df #4115

Merged
merged 3 commits into from
Jul 7, 2022
Merged

[full-ci] update reva to e2232b5a63df #4115

merged 3 commits into from
Jul 7, 2022

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 6, 2022

update reva to v2.6.2-0.20220706093852-e2232b5a63df

@butonic butonic self-assigned this Jul 6, 2022
@butonic butonic added the Category:Enhancement Add new functionality label Jul 6, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

@butonic butonic changed the title update reva to e2232b5a63df [full-ci] update reva to e2232b5a63df Jul 6, 2022
@butonic butonic force-pushed the update-reva-e2232b5a63df branch 2 times, most recently from a8f4de9 to fae65e8 Compare July 6, 2022 15:03
@phil-davis phil-davis force-pushed the update-reva-e2232b5a63df branch 2 times, most recently from 63e2035 to 57b43be Compare July 7, 2022 04:05
@phil-davis phil-davis self-requested a review July 7, 2022 04:06
@phil-davis phil-davis mentioned this pull request Jul 7, 2022
Merged
9 tasks
@phil-davis
Copy link
Contributor

phil-davis commented Jul 7, 2022 •
edited
Loading

https://drone.owncloud.com/owncloud/ocis/13143/75/14

runsh: Total unexpected failed scenarios throughout the test run:
apiWebdavOperations/downloadFile.feature:35

That failed again the same after I restarted.

  Background:                                                                                   # /drone/src/tests/parallelDeployAcceptance/features/apiWebdavOperations/downloadFile.feature:7
    Given using "oc10" as owncloud selector                                                     # ParallelContext::usingOwncloudSelector()
    And user "Alice" has been created with default attributes and without skeleton files        # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file with content "ownCloud test text file" to "textfile.txt" # FeatureContext::userHasUploadedAFileWithContentTo()

  Scenario: Get the size of a file                                              # /drone/src/tests/parallelDeployAcceptance/features/apiWebdavOperations/downloadFile.feature:35
    Given using "ocis" as owncloud selector                                     # ParallelContext::usingOwncloudSelector()
    When user "Alice" gets the size of file "textfile.txt" using the WebDAV API # FeatureContext::userGetsSizeOfFileUsingTheWebdavApi()
    Then the HTTP status code should be "207"                                   # FeatureContext::thenTheHTTPStatusCodeShouldBe()
      HTTP status code 404 is not the expected value 207
      Failed asserting that 404 matches expected '207'.
    And the size of the file should be "23"                                     # FeatureContext::theSizeOfTheFileShouldBe()

Other scenarios that actually download the file are passing.

When user "Alice" gets the size of file "textfile.txt" using the WebDAV API does a PROPFIND with depth 0 on the file. But that is returning a 404 "not found".

Failed again: https://drone.owncloud.com/owncloud/ocis/13144/75/14
It seems like a "hard" failure, not intermittent.

Did something change in reva code that might allow GET (download) to work across oC10<->oCIS in parallel, but that PROPFIND does not work?

@phil-davis phil-davis mentioned this pull request Jul 7, 2022
Open
@phil-davis
Copy link
Contributor

I raised issue #4122 and added this to the parallel-deployment expected-failures for now. Everything else passes, so someone could look into the issue separately.

@phil-davis
Copy link
Contributor

Codacy complains "[list-item-indent] Incorrect list-item indent: add 2 spaces" - but every other expected-failures file does not have that indent. I am ignoring it.

@phil-davis
Copy link
Contributor

More annoying stuff - the expected-failures-file linter from core does not understand where the referenced feature-files should be found. core PR owncloud/core#40184 will fix that.

@phil-davis phil-davis force-pushed the update-reva-e2232b5a63df branch 3 times, most recently from 8cd2b1a to 16b7db9 Compare July 7, 2022 07:03
@phil-davis
Copy link
Contributor

I will merge core owncloud/core#40184 and then adjust core commit id...

@phil-davis
Copy link
Contributor

Rebased again! The core commit id got updated just recently in a separate PR, so no need here any more.

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 8482cde into master Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-reva-e2232b5a63df branch July 7, 2022 11:18
ownclouders pushed a commit that referenced this pull request Jul 7, 2022
@phil-davis
commit 8482cde
2c92ce1 
Merge: aca849c e9ed371
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Jul 7 17:03:07 2022 +0545

    Merge pull request #4115 from owncloud/update-reva-e2232b5a63df

    [full-ci] update reva to e2232b5a63df
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@butonic butonic

Labels
Category:Enhancement Add new functionality
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @ownclouders @phil-davis